Remove updateMasterAdminPassword call in AbstractKeycloakTest #35895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes keycloak#35088 Signed-off-by: rmartinc <rmartinc@redhat.com>
mposolda
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35088
With the firefox driver sometimes when there are several redirects the
getPageSourcereturns null. It seems that it's much more problematic in the updateMasterAdminPassword call inAbstractKeycloakTestclass. For that reason a new waitForPageToLoad was added. But this is just a workaround that minimizes the problem. I think that the call to this method is just a leftover. Now we use the env variables to initialize the server. So the PR just removes the call. The method is maintained because it's used for some welcome page test.Without the
updateMasterAdminPasswordthe firefox Adapter IT Strict Cookies was executed 100 times without retries with no issues.