+
Skip to content

Conversation

kami619
Copy link
Contributor

@kami619 kami619 commented Dec 5, 2024

fixes #35640

@kami619 kami619 requested a review from ahus1 December 5, 2024 01:43
@ahus1
Copy link
Contributor

ahus1 commented Dec 5, 2024

@kami619 - thank you for this change. Pointing to the user metrics is a good start.

I would like it to be more specific about the events that are relevant to the sizing guide, so you would name login, refresh_token and client_login (not sure about the last one, please verify).

I see that it is currently part of the "Calculation example" section. If we would move it to its own section, we can add more context on when and how to use this. A draft statement in that new section could be "Use the the metrics X, Y and Z to measure the activity around user login, refresh token and client credential grant to validate your inputs for sizing calculation, monitor user activity load changes in the daily and weekly cycle, and watch out for trends that would require re-sizing your system".

If we see that the login event captures not only password based logins but also cookie based logins, this could be a note in the documentation as well. Maybe using some one the HTTP metrics can be a help to sort cookie based logins from password based logins: Password based logins will show as s POST once you submit the form, and the cookie based ones won't.

Please expand and add more context and details as needed :D

@kami619 kami619 force-pushed the is-35640-update-sizing-guide-user-event-metrics branch 2 times, most recently from 4e708a1 to 04a02da Compare December 6, 2024 12:01
@kami619
Copy link
Contributor Author

kami619 commented Dec 6, 2024

@ahus1 thanks for the feedback. I have updated the docs, but still couple of things are pending from how I want it to look, such as verifying the metrics for particular events.

You could still share me any more feedback based on the changes I did so far.

Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this initial draft, and for verifying the events.
See below for some nitpicks and comments.

@kami619 kami619 force-pushed the is-35640-update-sizing-guide-user-event-metrics branch 2 times, most recently from d538267 to eae3968 Compare December 6, 2024 15:37
@kami619 kami619 marked this pull request as ready for review December 6, 2024 15:38
@kami619 kami619 requested a review from a team as a code owner December 6, 2024 15:38
@kami619 kami619 force-pushed the is-35640-update-sizing-guide-user-event-metrics branch from eae3968 to 391a0b7 Compare December 6, 2024 15:41
@ahus1 ahus1 self-assigned this Dec 9, 2024
kami619 and others added 3 commits December 9, 2024 09:58
Signed-off-by: Kamesh Akella <kamesh.asp@gmail.com>
Signed-off-by: Kamesh Akella <kamesh.asp@gmail.com>
Co-authored-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Signed-off-by: Kamesh Akella <kakella@redhat.com>
@kami619 kami619 force-pushed the is-35640-update-sizing-guide-user-event-metrics branch from 391a0b7 to 0a43e4b Compare December 9, 2024 14:58
kami619 and others added 2 commits December 9, 2024 18:17
Co-authored-by: Alexander Schwartz <alexander.schwartz@gmx.net>
Signed-off-by: Kamesh Akella <kakella@redhat.com>
Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
@ahus1 ahus1 enabled auto-merge (squash) December 9, 2024 17:23
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I've updated the heading to capture more of the user's need, and added an introductory sentence.

The goal the overarching epic is that Keycloak can provide the necessary inputs to the sizing guide using metrics. With the password based login, we currently fall short here, which is a pity. I've added the HTTP server metrics as a substitution.

Let's discuss in the team how we can add a better metric here that allows for simpler sizing.

@ahus1 ahus1 merged commit 047b28a into keycloak:main Dec 9, 2024
54 checks passed
@kami619 kami619 deleted the is-35640-update-sizing-guide-user-event-metrics branch December 9, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the sizing guide with an indicator on which user events to use

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载