-
Notifications
You must be signed in to change notification settings - Fork 7.7k
update sizing guide with user event metrics info #35641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update sizing guide with user event metrics info #35641
Conversation
@kami619 - thank you for this change. Pointing to the user metrics is a good start. I would like it to be more specific about the events that are relevant to the sizing guide, so you would name I see that it is currently part of the "Calculation example" section. If we would move it to its own section, we can add more context on when and how to use this. A draft statement in that new section could be "Use the the metrics X, Y and Z to measure the activity around user login, refresh token and client credential grant to validate your inputs for sizing calculation, monitor user activity load changes in the daily and weekly cycle, and watch out for trends that would require re-sizing your system". If we see that the Please expand and add more context and details as needed :D |
4e708a1
to
04a02da
Compare
@ahus1 thanks for the feedback. I have updated the docs, but still couple of things are pending from how I want it to look, such as verifying the metrics for particular events. You could still share me any more feedback based on the changes I did so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this initial draft, and for verifying the events.
See below for some nitpicks and comments.
docs/guides/high-availability/concepts-memory-and-cpu-sizing.adoc
Outdated
Show resolved
Hide resolved
docs/guides/high-availability/concepts-memory-and-cpu-sizing.adoc
Outdated
Show resolved
Hide resolved
d538267
to
eae3968
Compare
eae3968
to
391a0b7
Compare
Signed-off-by: Kamesh Akella <kamesh.asp@gmail.com>
Signed-off-by: Kamesh Akella <kamesh.asp@gmail.com>
Co-authored-by: Alexander Schwartz <alexander.schwartz@gmx.net> Signed-off-by: Kamesh Akella <kakella@redhat.com>
391a0b7
to
0a43e4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. I've updated the heading to capture more of the user's need, and added an introductory sentence.
The goal the overarching epic is that Keycloak can provide the necessary inputs to the sizing guide using metrics. With the password based login, we currently fall short here, which is a pity. I've added the HTTP server metrics as a substitution.
Let's discuss in the team how we can add a better metric here that allows for simpler sizing.
fixes #35640