+
Skip to content

Conversation

ThomasAunvik
Copy link
Contributor

@ThomasAunvik ThomasAunvik commented Dec 4, 2024

Changes the referenced quote from

‘http-enabled’ 

to

`http-enabled`

As it is referenced in as a note with the incorrect quotes, doesn't turn itself into a mini-code block, whch in then doesn't show up in the "Relevant options" part of the page, which i assume is how this works.

https://www.keycloak.org/server/reverseproxy#_relevant_options

Relevant Issues:
#29665
#30170

Closes #35611

Copy link
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Could you please open and link an issue as per our contributing guidelines? That would help us a lot with tracking this.

@ThomasAunvik
Copy link
Contributor Author

@vmuzikar Thank you.

I have now created an issue #35611 .

And updated the commit message to be in line with the guidelines.

Closes keycloak#35611

Signed-off-by: Thomas Aunvik <contact@thaun.dev>
@jonkoops
Copy link
Contributor

jonkoops commented Dec 4, 2024

Please do not rebase the PR onto main unless there are conflicts, as this will result in additional notifications, and is not required to get your PR merged.

@ahus1 ahus1 enabled auto-merge (squash) December 4, 2024 17:31
@ahus1 ahus1 self-assigned this Dec 4, 2024
@ahus1 ahus1 merged commit 05884e8 into keycloak:main Dec 4, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code quote for http-enabled is incorrect, missing relevant option in reverse proxy documentation

4 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载