+
Skip to content

Allow updating the username when registration as email is enabled during LDAP updates #34961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2024
Merged

Allow updating the username when registration as email is enabled during LDAP updates #34961

merged 1 commit into from
Nov 15, 2024

Conversation

pedroigor
Copy link
Contributor

Closes #34560

@pedroigor
Allow updating the username when registration as email is enabled dur…
5df9b4c 
…ing LDAP updates

Closes keycloak#34560

Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
@pedroigor pedroigor requested review from a team as code owners November 14, 2024 13:37
@pedroigor pedroigor mentioned this pull request Nov 14, 2024
Closed
2 tasks
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Nov 14, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcSamlBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - Base IT (2)

java.lang.AssertionError: User should be disabled by brute force.
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:579)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

mposolda
mposolda approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@mposolda mposolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging on behalf of @sguilhen review

@mposolda mposolda merged commit dfe2f2b into keycloak:main Nov 15, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes

+2 more reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@sguilhen sguilhen sguilhen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switching 'Email as Username' alters existing custom usernames to email addresses, causing LDAP sync issues

3 participants

@pedroigor @sguilhen @mposolda
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载