make the tests capable of running against login v1 and v2 #33732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stianst the tests can now run against v1 and v2 only need some help setting up a nightly run against v1 |
This comment was marked as outdated.
This comment was marked as outdated.
fixes: keycloak#31764 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
stianst
reviewed
Nov 1, 2024
testsuite/integration-arquillian/tests/base/testsuites/login-suite
Outdated
Show resolved
Hide resolved
stianst
reviewed
Nov 1, 2024
stianst
reviewed
Nov 1, 2024
stianst
reviewed
Nov 1, 2024
…uite Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com>
Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com>
Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com>
Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com>
Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com>
Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com>
Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com>
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
stianst
reviewed
Nov 7, 2024
stianst
reviewed
Nov 7, 2024
stianst
reviewed
Nov 7, 2024
stianst
reviewed
Nov 7, 2024
stianst
requested changes
Nov 7, 2024
Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com>
Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com>
Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com>
Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com>
|
@stianst the tests fail now, because the login variable has no default |
That's ThemeSelectorTest and it's just failing because Hynek put in some changes there for this whole system property based theme selecting. Should be an easy fix. |
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
ssilvert
approved these changes
Nov 13, 2024
stianst
approved these changes
Nov 14, 2024
agagancarczyk
pushed a commit
to agagancarczyk/keycloak
that referenced
this pull request
Nov 28, 2024
…3732) * make the tests capable of running against login v1 and v2 fixes: keycloak#31764 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> * added build for v1 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> * Update testsuite/integration-arquillian/tests/base/testsuites/login-suite Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com> * Update .github/workflows/ci.yml Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com> * Update .github/workflows/ci.yml Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com> * Update .github/workflows/ci.yml Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com> * Update .github/workflows/ci.yml Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com> * Update .github/workflows/ci.yml Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com> * Update .github/workflows/ci.yml Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com> * added login default theme Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> * Update .github/workflows/ci.yml Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com> * Update .github/workflows/ci.yml Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com> * Update .github/workflows/ci.yml Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com> * Update .github/workflows/ci.yml Co-authored-by: Stian Thorgersen <stian@redhat.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com> * added default Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> --------- Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> Signed-off-by: Erik Jan de Wit <edewit@redhat.com> Co-authored-by: Stian Thorgersen <stian@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #31764
Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com