+
Skip to content

Conversation

senyahnoj
Copy link
Contributor

Directionality is set in the html opening tag only (in base/login/template.ftl)

See also related issue #33642 which is to fix directionality in keycloak.v2/login/template.ftl

Closes #32844

Directionality is set in the html opening tag only (in
base/login/template.ftl)

See also related issue keycloak#33642 which is to fix directionality in
keycloak.v2/login/template.ftl

Closes keycloak#32844

Signed-off-by: Jon Haynes <senyahnoj@gmail.com>
@senyahnoj senyahnoj requested review from a team as code owners October 8, 2024 07:50
@jonkoops
Copy link
Contributor

jonkoops commented Oct 8, 2024

@Eng-Fouad @Mouhand-Kaddo @sharifrezvani as maintainers of the RTL languages, is this how you would expect the UI to work? Or is it normal to force a LTR direction in some of these cases?

@Eng-Fouad
Copy link
Contributor

@Eng-Fouad @Mouhand-Kaddo @sharifrezvani as maintainers of the RTL languages, is this how you would expect the UI to work? Or is it normal to force a LTR direction in some of these cases?

Switching all UI components to RTL is the normal behavior. However, it is just a personal preference to use LTR for text inputs in cases where the text is English and it starts or ends with special characters.

For instance, let's assume we have 2 usernames named _abc and def$, here is how it would look on RTL text inputs:

rtl

and here how it would look on LTR text inputs:

ltr

@jonkoops
Copy link
Contributor

jonkoops commented Oct 8, 2024

Thanks for that feedback. Then if it is just personal preference I would say let's opt for going full RTL when a RTL language is enabled, as that simplifies things technically and reduces the amount of variants.

@jonkoops
Copy link
Contributor

jonkoops commented Oct 8, 2024

@ahus1 since you have been involved in the other PRs and issues related to this, can I ask you for your take as well?

@ahus1
Copy link
Contributor

ahus1 commented Oct 8, 2024

I was merely the person who spotted the HTML change. I have no experience with LTR languages at all.

Switching all UI components to RTL is the normal behavior. However, it is just a personal preference to use LTR for text inputs in cases where the text is English and it starts or ends with special characters.

With @Eng-Fouad's comment above, I'd like to hear @senyahnoj's if this changed his mind, if if he wants to continue with the PR as is.

Another aspect:

This changes both the Login v1 and v2 themes. As this was originally what the v2 themes should do, I'd like to keep the v1 theme stable as this is the "old" theme we want people to migrate from.

The reason I pointed towards the old theme was not to change the old theme, but to highlight that it was different in v1 for quite a while than it now in v2. I'm sorry if this caused confusion and extra work here.

@jonkoops
Copy link
Contributor

jonkoops commented Oct 8, 2024

This changes both the Login v1 and v2 themes. As this was originally what the v2 themes should do, I'd like to keep the v1 theme stable as this is the "old" theme we want people to migrate from.

I was contemplating this as well, I feel like it should still be fine to land fixes in V1, but considering this is mostly a matter of opinion I agree the changes should only be applied for V2. This also simplifies any backporting to 26.0.1 we might want to do.

@senyahnoj could you make the proposed changes?

@ssilvert ssilvert self-assigned this Oct 8, 2024
@senyahnoj
Copy link
Contributor Author

OK. In that case I shall close this PR with the changes to both "base" and "keycloak.v2" and reinstate my previous PR which only made the change in the keycloak.v2 template #33652

@senyahnoj senyahnoj closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Login V2: Missing "dir" attributes

5 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载