Ensure regex policies work for multi-valued claims #33674
+57
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RegexPolicyProvider, execute the regex match on a string containing all claims, separate by comma Closes keycloak#33293 Signed-off-by: Paul-Andrei Bujor <bujor.paul2000@gmail.com>
ahus1
requested changes
May 14, 2025
There was a problem hiding this comment.
I had a look and IMHO switching from match to find would break the existing logic. For multivalued attributes, I would expect it to apply the match logic on each element individually. I would avoid concatenating the string as it opens the door to a lot of confusion of delimiters.
Signed-off-by: Paul-Andrei Bujor <git@paulbujor.net>
6ed3109 to
f210bed
Compare
|
@ahus1 thanks for the feedback - made some updates. i guess I'll have to merge commits and rebase once it's ok? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RegexPolicyProvider, execute the regex match on a string containing all claims, separate by comma
Closes #33293