+
Skip to content

docs: align on one realm-name placeholder #32912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2024
Merged

docs: align on one realm-name placeholder #32912

merged 1 commit into from
Dec 19, 2024

Conversation

janv8000
Copy link
Contributor

@janv8000 janv8000 commented Sep 13, 2024 •
edited by ahus1
Loading

Closes #36047

Based on rg "\{realm.*?\}" --no-filename -o --no-line-number | sort-uniq-count-rank realm-name prevails.

@janv8000 janv8000 requested review from a team as code owners September 13, 2024 14:27
@jonkoops
Copy link
Contributor

Thanks for the PR. Could you sign off on your commit and log an issue and link it to this PR?

@janv8000 janv8000 mentioned this pull request Sep 17, 2024
Open
@janv8000 janv8000 force-pushed the realmname_placeholder branch 2 times, most recently from 16b1f97 to 522fae2 Compare September 17, 2024 09:24
@janv8000 janv8000 force-pushed the realmname_placeholder branch from 522fae2 to f704781 Compare October 3, 2024 09:06
@janv8000 @ahus1
feat: align on one realm-name placeholder
3b9df6d 
Based on `rg "\{realm.*?\}" --no-filename -o --no-line-number --iglob=*.adoc | sort-uniq-count-rank` **realm-name** prevails

Signed-off-by: Jan Verhaeghe <jan@hwfaq.be>
@ahus1 ahus1 force-pushed the realmname_placeholder branch from f704781 to 3b9df6d Compare December 19, 2024 13:40
@ahus1
Copy link
Contributor

ahus1 commented Dec 19, 2024

I ran the following command I confirm the finding - note the added filter for just docs files

$ rg "\{realm.*?\}" -o --no-filename --no-line-number --iglob=*.adoc | sort | uniq -c 
     52 {realm}
      1 {realm name}
     57 {realm-name}
     23 {realm_name}

@ahus1 ahus1 enabled auto-merge (squash) December 19, 2024 13:46
@ahus1 ahus1 self-assigned this Dec 19, 2024
@ahus1 ahus1 merged commit 5624609 into keycloak:main Dec 19, 2024
54 checks passed
@janv8000 janv8000 deleted the realmname_placeholder branch March 28, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes

Assignees

@ahus1 ahus1

Labels

team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Align realm name placeholder in the docs

3 participants

@janv8000 @jonkoops @ahus1
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载