RawKeycloakDistribution exit code is always 0

### Before reporting an issue

- [x] I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.

### Area

testsuite

### Describe the bug

When making a distribution run with non-zero exit in the testsuite the `RawKeycloakDistribution`  does not provide correct exit code.





### Version

main

### Regression

- [ ] The issue is a regression

### Expected behavior

When running this distribution run: https://github.com/keycloak/keycloak/blob/3c0fc83842a43b358a350722b3b2b92b9dc91d2f/quarkus/tests/integration/src/test/java/org/keycloak/it/cli/dist/UpdateCommandDistTest.java#L96 

the expected call to `result.exitCode()` should return non-zero exit code.

### Actual behavior

The run return 0.

### How to Reproduce?

Run the following test in debug mode: https://github.com/keycloak/keycloak/blob/3c0fc83842a43b358a350722b3b2b92b9dc91d2f/quarkus/tests/integration/src/test/java/org/keycloak/it/cli/dist/UpdateCommandDistTest.java#L87-L107

The result on line 96 should have non-zero exit code, however, the exit code is 0.

### Anything else?

_No response_

	public void testWrongVersions(KeycloakDistribution distribution) throws IOException {
	var jsonFile = createTempFile("wrong-versions");

	// incompatible keycloak version
	var info = new ServerInfo();
	info.setVersions(Map.of(CompatibilityManagerImpl.KEYCLOAK_VERSION_KEY, "0.0.0.Final",
	CompatibilityManagerImpl.INFINISPAN_VERSION_KEY, org.infinispan.commons.util.Version.getVersion()));
	JsonSerialization.mapper.writeValue(jsonFile, info);

	var result = distribution.run(UpdateCompatibility.NAME, UpdateCompatibilityCheck.NAME, UpdateCompatibilityCheck.INPUT_OPTION_NAME, jsonFile.getAbsolutePath(), ENABLE_FEATURE);
	result.assertError("[Versions] Rolling Upgrade is not available. 'keycloak' is incompatible: Old=0.0.0.Final, New=%s".formatted(Version.VERSION));

	// incompatible infinispan version
	info.setVersions(Map.of(
	CompatibilityManagerImpl.KEYCLOAK_VERSION_KEY, Version.VERSION,
	CompatibilityManagerImpl.INFINISPAN_VERSION_KEY, "0.0.0.Final"));
	JsonSerialization.mapper.writeValue(jsonFile, info);

	result = distribution.run(UpdateCompatibility.NAME, UpdateCompatibilityCheck.NAME, UpdateCompatibilityCheck.INPUT_OPTION_NAME, jsonFile.getAbsolutePath(), ENABLE_FEATURE);
	result.assertError("[Versions] Rolling Upgrade is not available. 'infinispan' is incompatible: Old=0.0.0.Final, New=%s".formatted(org.infinispan.commons.util.Version.getVersion()));
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

RawKeycloakDistribution exit code is always 0 #38161

Before reporting an issue

Area

Describe the bug

Version

Regression

Expected behavior

Actual behavior

How to Reproduce?

Anything else?

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

RawKeycloakDistribution exit code is always 0 #38161

Description

Before reporting an issue

Area

Describe the bug

Version

Regression

Expected behavior

Actual behavior

How to Reproduce?

Anything else?

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions