Remove the unnecessary r-value reference #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frame is move only in any case
|
Is the title wrong? The changes here are to rvalue references not to the universal references |
|
Yes, indeed. Title should be r-value not universal reference |
I think it's only F.18 that applies here, and the key part is for why making this change is just simplicity:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frame is move only in any case
BEGINRELEASENOTES
MetadataSvc.ENDRELEASENOTES
Mainly because I saw this lightning talk yesterday and this seems to be a case where it's unnecessary.
(We have this in quite a few places, where the move-only property of our types already ensures that a
std::moveon the calling site is necessary if not using a temporary)