IOSvc: Minor fixes for improving usage and errors #213
Conversation
348fe67 to
b9113e2
Compare
|
This should be ready to be merged. I will merge today if there aren't any comments. |
There was a problem hiding this comment.
This should be changed to .Input and .Output too, no?
k4FWCore/test/k4FWCoreTest/options/runFunctionalMix.py
Lines 69 to 71 in 005dd3e
There was a problem hiding this comment.
If think it might be simpler if we say to just always import ApplicationMgr from k4FWCore rather than if there is IOSvc then import from k4FWCore otherwise import from k4FWCore or Configurables.
In a similar vain maybe all the examples could import from k4FWCore rather than importing from Configurables when possible?
Maybe in a longer run we could port our custom python wrappers (ApplicationMgr.py, IOSvc.py) back to C++ (no extra checks or python parsing needed on our side, users can import all they need from Configurables, easier to extend by users if needed)
005dd3e to
c1da2ad
Compare
I agree this is a good idea and now all the examples import from k4FWCore.
About this I'm not sure, for |
6afb58f to
df2aace
Compare
…bles since a few features depend on it and when it fails it's not clear that importing from Configurables is the reason.
BEGINRELEASENOTES
IOSvcorApplicationMgrare not imported withfrom k4FWCore import IOSvc(it can be imported fromConfigurables). The python wrapper in k4FWCore does a few minor things and importing fromConfigurablesdoesn't fail currently and can lead to hard to solve issues.eventscategory. Currently it fails with an error in python that is not very clear.InputandOutputfor IOSvc, deprecateinputandoutputsince all the other properties are capitalized. The same forIOTypeinstead ofioType. This will print a warning about a duplicated property that should be ignored for now.EventLoopMgr.ApplicationMgralways fromk4FWCoreENDRELEASENOTES
The two warnings are these:
they will appear always and this feature is not being used. In any case, this only overrides the default case, someone can create an
EventLoopMgrand have the warnings. I opened an issue in Gaudi.The most important is failing when importing
ApplicationMgrfromConfigurablesas most of the examples do not set the algorithms for reading and writing that the user doesn't need to worry about in almost any case, but the wrapper ink4FWCoredoes so one only needs to specifyIOSvc.InputorIOSvc.Output.