+
Skip to content

Improve platform detection performance and link generating performance #19

@keevan

Description

@keevan
  • Not every platform needs to parse and detect certain headers, which means the platform and relevant URLs could be generated (almost) instantly, as opposed to waiting for the HEAD request's response (as a current form of detection for non public, self-hosted platforms)
  • Implementation could potentially use generators (yield), but preferably the interface should be as if there was only ever one platform to check. The generator approach might be interesting to code.
  • Detected platform could be cached, but caching itself poses a risk of being incorrect when the state of things checked, is changed especially if it happens outside of Atom or when this package is not aware of it. I think some caching is okay, but caching things like the git remote origin is risky. This is to reduce the amount of potential git exec calls, which other than DB and web requests are usual culprits of performance issues.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载