+
Skip to content

Added Gem.clear_paths to bundler.erb #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Added Gem.clear_paths to bundler.erb #437

wants to merge 2 commits into from

Conversation

rsov
Copy link
Contributor

@rsov rsov commented Jul 19, 2018

Tried deploying with Bundler 1.16.3 and it did not seem to resolve the issues with #432

Submitting the fix again (with proper method call this time)

@rsov
Copy link
Contributor Author

rsov commented Jul 24, 2018

Should fix #432, #430 and #415

@timbogit
Copy link

timbogit commented Aug 8, 2018

@rsov / @ kares : any chance this fix can be merged soon?
Using the branch for this PR locally in our (JRuby 9.2.0.0) project appears to resolve the issue.
I see that the Travis build is broken for one version, though. Maybe that can be addressed?
Or is the preferred solution to wait for a change in bundler to be released (as mentioned in #432 ) and then hope that fixes 9.2.0.0 support?

@rsov
Copy link
Contributor Author

rsov commented Aug 8, 2018

@timbogit I have tried it with updated version of bundler and it did not fix the issue

@rsov rsov force-pushed the fix_bundler_shared_helpers branch from 2b9b690 to a930498 Compare August 8, 2018 19:18
@rsov
Copy link
Contributor Author

rsov commented Aug 8, 2018

It looks like it could not find rake-10.5 when using run_in_directory in "when frozen".

Added bundle_install to one of the top specs to install the needed version of rake. That fixed the issue

@rsov rsov force-pushed the fix_bundler_shared_helpers branch from 8336e7c to 9283ec3 Compare August 8, 2018 20:32
@timbogit
Copy link

timbogit commented Aug 8, 2018

Thanks so much, @rsov !

@kares : any chance this fix is acceptable, so that warbler can support JRuby 9.2.0.0?

@kares
Copy link
Member

kares commented Aug 9, 2018

as noted previously, this isnt a good work-around #432 (comment) ... likely a JRuby 9.2 bug

@dennis-d dennis-d mentioned this pull request Aug 14, 2018
Closed
@mungler
Copy link

mungler commented Nov 7, 2018

Bug appears to be still present in JRuby 9.2.1.0 :/

@rsov rsov closed this Sep 9, 2024
@rsov rsov deleted the fix_bundler_shared_helpers branch September 9, 2024 06:05
@chadlwilson chadlwilson mentioned this pull request Oct 9, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rsov @timbogit @kares @mungler
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载