Completes #37 #38
Merged
Completes #37 #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an interface for [https://github.com/BurntSushi/toml-test](toml-test). That being said we do fail some of the tests and should probably look into fixing the failing tests.
|
Hey! Thanks for the pull request. Is something wrong with what I did in #35? |
|
Sorry about that, I don't see anything wrong with #35. I had just checked the state of the tests with my git checkout and should have checked the PRs before creating this one. One thing that #35 doesn't do is add an interface for testing the encoder. toml-test can be run with the |
parkr
added a commit
that referenced
this pull request
Sep 25, 2014
Add toml-test interface. Completes #37
|
@parkr do you think you'll release this as a gem build anytime soon? I'm having to deploy a manual gem build with these fixes right now and would rather use your build off rubygems. |
|
Yep! |
|
Thank you 👍 |
|
Perfect. That helps a ton! |
|
My pleasure – let me know if I can help out further! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an interface for toml-test. That being said we
do fail some of the tests and should probably look into fixing the failing tests.