Add Args.count() #381
Add Args.count() #381
Conversation
CohenArthur
commented
Nov 30, 2021
- parser: WIP: Parse empty types -> Read message
- empty_types: Add empty type parsing and instantiation
- empty_types: Instantiate empty types on the fly
- stdlib: Add Args.count() function
- stdlib: Make Args type an empty type
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
==========================================
- Coverage 91.73% 91.63% -0.10%
==========================================
Files 37 38 +1
Lines 3979 4043 +64
==========================================
+ Hits 3650 3705 +55
- Misses 329 338 +9
Continue to review full report at Codecov.
|
| type Ok; | ||
| type NotOk; | ||
|
|
||
| o = Ok; |
There was a problem hiding this comment.
I'm not sure if this is a good design. Is o the type Ok or an instance of Ok (I know it's the latter but that a bit confusing).
Why not just go with the usual Ok() rather than creating a special edge case that complexify the language.
What is the benefit of this outside of removing the need of ()
There was a problem hiding this comment.
Oops... that's my bad for having the wrong destination branch, but this discussion is more suited on #348. I'll answer there
92c29da to
8363e69
Compare