docker: add basic Dockerfile to run jinko interpreter #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #370 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 42 42
Lines 4208 4208
=======================================
Hits 3906 3906
Misses 302 302 Continue to review full report at Codecov.
|
d065f28 to
d38e801
Compare
|
Soooo, I decided to use an archlinux base image to run the binary, so we can have access to all the needed libraries. Now it should be better, let me know what you think :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a simple Dockerfile to run the jinko interpreter directly.
I tried splitting it in two (one layer for build, and one for run) but without any success, I guess the binary cannot be run without rust libraries.
Tell me what you think and I shall adjust my pull request to please your needs.