+
Skip to content

Conversation

Skallwar
Copy link
Member

In order to make repl.jinko.ml to work correctly, we need to have an eval function.

For now I think that Context is a good home. But I will let this in draft until the code architecture refactor is done.

We also need to figure out how we want to be able to log error and ouptut somewhere else than stdout and stderr

@Skallwar Skallwar mentioned this pull request Dec 15, 2021
5 tasks
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sadly we're gonna have to do something more complex than this in order to get evals :(

@Skallwar Skallwar force-pushed the add_eval branch 4 times, most recently from 5f362d3 to 212658b Compare December 22, 2021 19:12
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks :)

@Skallwar Skallwar marked this pull request as ready for review December 23, 2021 17:13
@Skallwar Skallwar merged commit cc69b8c into master Dec 23, 2021
@Skallwar Skallwar deleted the add_eval branch December 23, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载