+
Skip to content

Improve 'tome new' template with cowsay style ASCII art #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2025

Conversation

czoido
Copy link
Collaborator

@czoido czoido commented May 23, 2025

Improving the template for a more visually engaging output.

$ tome greetings:hello Hi -o="this is a test"

 ____________________
< Hi, this is a test >
 --------------------
        \\   @..@
         \\ (----)
           ( >__< )
           ^^ ~~ ^^

@czoido czoido requested a review from Copilot May 24, 2025 06:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the tome new template by introducing a frog-themed ASCII speech bubble, updating argument names, and adjusting tests and shell script headers for consistency.

  • Add a docstring and replace format_message with frog_<command> to generate a cowsay-style speech bubble
  • Rename positional and optional arguments (positional_argumentpositional, --optional-argument-o/--optional)
  • Update generated unit and integration tests and shell/batch script templates

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tome/commands/new.py Python template: docstring, frog_ function, arg renames, tests
tests/integration/test_new.py Integration test: updated flag name and output assertion
tests/integration/test_install.py Integration test: simplified output check for install commands
Comments suppressed due to low confidence (1)

tome/commands/new.py:37

  • [nitpick] The raw multi-line string for ASCII art includes leading indentation, causing extra spaces in output. Consider using textwrap.dedent or aligning the art against the left margin to remove unintended whitespace.
frog = r"""

@czoido czoido merged commit 44517af into main May 24, 2025
13 checks passed
@czoido czoido deleted the czoido/improve-tome-new branch June 2, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载