+
Skip to content

add --smtputf8 support #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

wolfgangkarall
Copy link
Contributor

Hi John,

this is just adding support for the SMTPUTF8 parameter in the MAIL command, closely following the change in 9ce7181 for --prdr support.

Cheers
Wolfgang

@jetmore jetmore added the enhancement New functionality slated to be implemented someday label Nov 5, 2023
@jetmore jetmore added this to the backlog-feature milestone Nov 13, 2023
@augmentedfourth
Copy link

@jetmore This is a great patch. Is there a reason it didn't get added in v20240103.0?

@jetmore
Copy link
Owner

jetmore commented Feb 9, 2024

@augmentedfourth (great username) no specific reason beyond time. It's not just accepting the PR, it's making sure I understand the problem space and the fix, adding testing, and feeling comfortable enough to be responsible for the implementation moving forward. I'll add it to the next milestone for consideration though

@jetmore jetmore modified the milestones: backlog-feature, next Feb 9, 2024
@augmentedfourth
Copy link

Ok, cool. I've manually applied this patch to a more recent version a couple of different times now, to test internationalization for the systems/platform at $WORK. Given how infrequently swaks has new releases, I was hoping to see it merged in last month's update.

@polarathene
Copy link

It's not just accepting the PR, it's making sure I understand the problem space and the fix, adding testing, and feeling comfortable enough to be responsible for the implementation moving forward

If you have any queries regarding the XOAUTH2 PR, feel free to ping me. I am reasonably familiar with it after my involvement with support in DMS and curl.

@jetmore jetmore changed the base branch from develop to 20-smtputf8 March 5, 2024 20:16
@jetmore jetmore merged commit 6501745 into jetmore:20-smtputf8 Mar 5, 2024
@jetmore
Copy link
Owner

jetmore commented Mar 6, 2024

I pulled this into a local branch to tweak it a little, but I intend that this will be supported in the next release, thank you @wolfgangkarall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New functionality slated to be implemented someday
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载