Improve TLS transaction debugging around client and peer certificates #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In prep for handling peer chains properly, change the printing of local cert labeling from local/chain to local[i], but only if there is more than one local cert. eg, 1 cert => "local DN"; >1 cert => "local[0] DN, local[1] DN", etc
…d cert Note that many of the tests have multiple copies of the same cert in their output. I think this is an issue w/ smtp-server.pl, not swaks. See #73
another openssl upgrade on my laptop, another form of this error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print entire peer cert chain, not just the "peer cert"
improve formatting on printing certs (for both local and peer certs) to include date, CN, and SAN information