+
Skip to content

coro::when_any test failure #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025
Merged

Conversation

jbaldwin
Copy link
Owner

This test on github actions seems to fail quite regularly, giving it a bump in how long the task that shouldn't complete 4x the amount of time to see if this resolves the issuue (I think the github servers are just very overloaded and a 40ms difference isn't enough to have it trigger properly every time, lets see if 190ms is enough.)

Closes #355

@jbaldwin jbaldwin self-assigned this Jul 15, 2025
@jbaldwin jbaldwin added the bug Something isn't working label Jul 15, 2025
@jbaldwin jbaldwin force-pushed the issue-355/when-any-test-failure-fix branch 2 times, most recently from e1d0c44 to 7e844f2 Compare July 17, 2025 19:55
This test on github actions seems to fail quite regularly, giving it a
bump in how long the task that shouldn't complete 4x the amount of time
to see if this resolves the issuue (I think the github servers are just
very overloaded and a 40ms difference isn't enough to have it trigger
properly every time, lets see if 190ms is enough.)

Likely was a race condition with the stop_token being set and both tasks
returning as quickly as possible, sometimes on github this would cause
the actual task to return before the timeout job that triggered the stop
token.

Closes #355
@jbaldwin jbaldwin force-pushed the issue-355/when-any-test-failure-fix branch from 7e844f2 to 6775d4c Compare July 17, 2025 20:33
@jbaldwin jbaldwin merged commit 10ca7de into main Jul 19, 2025
63 of 64 checks passed
@jbaldwin jbaldwin deleted the issue-355/when-any-test-failure-fix branch July 19, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When any test failure
1 participant
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载