Support creating hard links #301 #310
Conversation
|
Thanks for putting this together! For code coverage, please clone the existing |
gitman/shell.py
Outdated
|
|
||
| # delete directories from target not present in source | ||
| for dir in target_dirs: | ||
| rm(dir) |
There was a problem hiding this comment.
I'm trying to understand why all this code is required. Is just calling os.link(source, target) insufficient?
There was a problem hiding this comment.
It is not needed for the initial run, but will most likely be necessary on sequential runs.
Say your source repo has three files, a, b & c. On the initial run you will get links to a, b & c in your target directory.
Now let's say the author of the source repo adds file d and removes a, meaning files b, c & d are the content on the source. Without this extra code, you will however end up with a, b, c & d on the target, instead of b, c & d.
That might take some time, as said before I'm not a Python developer; before this I had hardly done more than a hello world in Python. |
…kinds of links Co-authored-by: Jace Browning <jacebrowning@gmail.com>
Co-authored-by: Jace Browning <jacebrowning@gmail.com>
…ies not present in source from target
|
@jacebrowning please add a "help wanted" label. The code works, but I need help with the testing. The tests in GitHub does not pass, but it pass (make {check,test}) on my box (Debian 11 with Python 3.8 using pyenv). As I am not a Python programmer this is the limits of my knowledge and effort. |
#301