+
Skip to content

Conversation

asteele0
Copy link

@asteele0 asteele0 commented Nov 9, 2022

I had a scenario where I needed to also specify custom arguments to the git fetch command, in addition to git clone. This wasn't supported, so I've added it as just another YAML option.

Pretty much just copied the implementation of user_params in most places.

Tests run and all but 3 succeed, which is how many failed when I ran them before these changes.

@jacebrowning
Copy link
Owner

What additional fetch params did you need in your scenario? I wonder if there's a commonality with clone.

@asteele0
Copy link
Author

asteele0 commented Nov 9, 2022

What additional fetch params did you need in your scenario? I wonder if there's a commonality with clone.

I needed --depth 1 specifically, but I could also see people wanting --prune, or --verbose too.

@jacebrowning
Copy link
Owner

I needed --depth 1 specifically

Then perhaps this feature can start by sharing params configuration option and passing it to both clone and fetch, which have many of the same options.

I could also see people wanting --prune, or --verbose

I think I would rather see those as command-line options passed to gitman rather than stored in the configuration file. gitman -v2 could make git more verbose, for example.

@asteele0
Copy link
Author

asteele0 commented Nov 9, 2022

Then perhaps this feature can start by sharing params configuration option and passing it to both clone and fetch, which have many of the same options.

While they do share some parameters, there are many that they also don't share.
I did a diff on the options from the manual (it's not perfect, but it's close enough):
https://www.diffchecker.com/iGgPsZWj

I think I would rather see those as command-line options passed to gitman rather than stored in the configuration file. gitman -v2 could make git more verbose, for example.

That makes sense to me. Could pass that down to everything applicable, which might make debugging easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载