jxcore: moved node::removeCommons() outside AutoScope scope #793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the AutoScope object goes out of scope in the JXEngine::Destroy method it uses members of main_node_ that prior to this fix had already been destroyed by the node::removeCommons() call. This fix moves the node::removeCommons autoside the lifetime scope of the AutoScope object, such that it's guaranteed that all members of main_node_ are still dereferenceable.
|
@JorisKoster Thanks! |
obastemur
added a commit
that referenced
this pull request
Jan 22, 2016
…roying-engine jxcore: moved node::removeCommons() outside AutoScope scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the AutoScope object goes out of scope in the JXEngine::Destroy method it uses members of main_node_ that prior to this fix had already been destroyed by the node::removeCommons() call. This fix moves the node::removeCommons autoside the lifetime scope of the AutoScope object, such that it's guaranteed that all members of main_node_ are still dereferenceable.