+
Skip to content

Keyboard shortcuts #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2021
Merged

Keyboard shortcuts #283

merged 3 commits into from
Feb 21, 2021

Conversation

Liance
Copy link
Contributor

@Liance Liance commented Jun 13, 2020

We get a lot of people asking about Find and Replace in the Ink discord, which indicates it's not a feature that's very obviously surfaced.

Find and Replace in Inky does, in fact, exist, and is provided by the Ace editor that Inky is built on. It's just not on a very intuitive keyboard shortcut - Ctrl+H - and at the moment there's no way to know this except through trial and error keyboard mashing or by googling "Ace editor keyboard shortcuts", which...also isn't intuitive.

What I wanted to do was hook up Find and Replace to the menu directly, but unfortunately, after a day or so of trying to do this, I couldn't find a way to do this that was achievable by me, and/or wouldn't break the next time we updated the ace editor library!

So, rather than introducing a lot of spaghetti for a feature that already exists, I was thinking we could put a list of keyboard shortcuts in the place people will first look when searching for a Find and Replace function: in the edit menu.

image

The menu that appears is ugly but functional, and should tell people everything they want to know about find and replace (and a bit more).

image

It's been implemented in the exact same way that the story stats menu option was, which you can see below here:
image

With luck, this should reduce the amount of people who need to go to the Ink discord to find out how to Find and Replace in Inky!

@joethephish
Copy link
Member

Apologies for the long delay, and thanks!

@joethephish joethephish merged commit 9e6d493 into inkle:master Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载