+
Skip to content

Support OTP 28 #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 14, 2025
Merged

Support OTP 28 #466

merged 4 commits into from
Jun 14, 2025

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

@paulo-ferraz-oliveira paulo-ferraz-oliveira commented Jun 11, 2025

Description

There's a few assumptions here, but since I wanna split this from #463, I'm doing it already.

Further considerations

This most likely required inaka/katana-code#91 being accepted, merged and released (for later import here).

@paulo-ferraz-oliveira paulo-ferraz-oliveira added this to the 4.2.0 milestone Jun 11, 2025
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Tentatively assigning this to 4.2.0.

Base automatically changed from fix/operator-spaces-out-of-scope to main June 11, 2025 16:05
@elbrujohalcon
Copy link
Member

https://hex.pm/packages/katana_code/2.4.0 is ready 💪🏻

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Here it comes 😄... lemme see how fast I can do this. And by "fast" I don't mean sloppy, I mean "easy"...

@paulo-ferraz-oliveira paulo-ferraz-oliveira marked this pull request as ready for review June 13, 2025 20:05
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Feel free to release at whatever moment, no pressure. If you end up having this in 4.1.0 do adjust the milestone here and in the linked issue.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

You probably need to remove

image

from the Settings. I can't, it seems...

@paulo-ferraz-oliveira paulo-ferraz-oliveira modified the milestones: 4.2.0, 4.1.0 Jun 13, 2025
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Hm... this is failing for no_debug_calls when trying to fetch by call. All the other tests pass, and even the same test if the file is read from .beam.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

This is now waiting for e.g. 2.4.1 from katana_code.

@elbrujohalcon
Copy link
Member

https://hex.pm/packages/katana_code/2.4.1 is here :)

@paulo-ferraz-oliveira
Copy link
Collaborator Author

And this is now updated and being tested.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

@elbrujohalcon, #466 (comment).

@paulo-ferraz-oliveira
Copy link
Collaborator Author

I think we're getting bit by this: erlang/rebar3#2954. Good news: there seems to be a fix on the way... I'll move this to 4.2.0, so we have more time to fix it.

@paulo-ferraz-oliveira paulo-ferraz-oliveira modified the milestones: 4.1.0, 4.2.0 Jun 14, 2025
@elbrujohalcon
Copy link
Member

Well… CI worked in all the required ones… I'll merge this PR. We can upgrade rebar3 in the next one :)

@elbrujohalcon elbrujohalcon merged commit 8311853 into main Jun 14, 2025
11 of 13 checks passed
@elbrujohalcon elbrujohalcon deleted the feature/otp-28 branch June 14, 2025 14:34
@elbrujohalcon elbrujohalcon modified the milestones: 4.2.0, 4.1.0 Jun 14, 2025
@paulo-ferraz-oliveira
Copy link
Collaborator Author

Well… CI worked in all the required ones…

Oh, Ok, I thought the required and CI range was similar. In any case, if rebar3 doesn't go 3.26 but e.g. 3.25.1 we'll get the CI update automatically given how setup-beam works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载