+
Skip to content

Release predicate v0.2 #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Release predicate v0.2 #495

wants to merge 4 commits into from
+23 −6

Conversation

bdehamer
Copy link

@bdehamer bdehamer commented Oct 7, 2025

Closes #492

Bumps the release predicate from v0.1 to v0.2 in order to rename the releaseId predicate field to packageId.

Rendered version

@bdehamer
release predicate v0.2
12ccefd 
Signed-off-by: Brian DeHamer <bdehamer@github.com>
@bdehamer bdehamer requested a review from a team as a code owner October 7, 2025 13:49
marcelamelara
marcelamelara requested changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bdehamer ! The spec changes LGTM, but can you please also update the corresponding .proto file under protos/ ? No need to regenerate the language bindings, since that's handled by the CI.

@bdehamer
add proto for release predicate v0.2
1e96a19 
Signed-off-by: Brian DeHamer <bdehamer@github.com>
@bdehamer bdehamer force-pushed the release-predicate-v02 branch from 8b2c223 to 1e96a19 Compare October 8, 2025 14:43
@bdehamer
Copy link
Author

bdehamer commented Oct 8, 2025

@marcelamelara I noticed that the previous release proto was in release/v0 (and use similarly named v0 package names in the proto def itself). I'm assuming that we do NOT want to just update the proto in-place, so i added a new release/v0.2 directory.

Lemme know if this is not the correct approach.

@bdehamer bdehamer requested a review from marcelamelara October 8, 2025 14:46
@marcelamelara
Copy link
Contributor

@bdehamer Thanks for adding that. Yes, given that this isn't a backwards compatible change, creating a separate v0.2 directory. Does it make sense to rename the current release/v0 directory to release/v0.1? We did this for another predicate when we had a similar situation, but I don't know how many implementations depend on the current directory.

@bdehamer
linter fixes for release predicate spec
35f2205 
Signed-off-by: Brian DeHamer <bdehamer@github.com>
@bdehamer
move v0.1 release proto to new dir
86ac58e 
Signed-off-by: Brian DeHamer <bdehamer@github.com>
@bdehamer
Copy link
Author

Updated!

marcelamelara
marcelamelara approved these changes Oct 11, 2025
View reviewed changes
Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @bdehamer !

@marcelamelara marcelamelara requested a review from a team October 11, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelamelara marcelamelara marcelamelara approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider renaming releaseId in release attestation

2 participants

@bdehamer @marcelamelara
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载