+
Skip to content

refactor!: remove testutil.Register function #4703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented May 23, 2025

Description

Remove testutil.Register function and add it to the global app folders. We don't need support for a long time, all chains already come with the test helpers files.

@Pantani Pantani self-assigned this May 23, 2025
@Pantani Pantani requested review from ilgooz and julienrbrt as code owners May 23, 2025 17:26
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:templates component:configs type:services Service-related issues. labels May 23, 2025
@Pantani Pantani requested a review from toschdev as a code owner May 23, 2025 17:27
@Pantani Pantani enabled auto-merge (squash) May 23, 2025 17:52
@julienrbrt julienrbrt changed the title chore: remove testutil.Register function refactor!: remove testutil.Register function May 23, 2025
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@julienrbrt julienrbrt disabled auto-merge May 23, 2025 18:23
@julienrbrt
Copy link
Member

image
that explains why auto merge didn't work nor merging manually

@julienrbrt julienrbrt merged commit 96ce25d into main May 23, 2025
44 checks passed
@julienrbrt julienrbrt deleted the chore/remove-unused-register branch May 23, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ci CI/CD workflow and automated jobs. component:configs component:templates type:services Service-related issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载