Add NetworkByChainID function to return network and blockchain for registered ChainID #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| if _, ok := chainIDs[k]; !ok { | ||
| return 0, fmt.Errorf("chainID not registered for %s:%s", blockchain, network) | ||
| return 0, fmt.Errorf("%w for %s:%s", ErrChainIDNotRegistered, blockchain, |
There was a problem hiding this comment.
Retrun NoChain constant?
There was a problem hiding this comment.
NoChain has a Blockchain type, not ChainID.
demonsh
approved these changes
Jan 30, 2024
Kolezhniuk
reviewed
Jan 30, 2024
|
|
||
| var ErrChainIDNotRegistered = errors.New("chainID is not registered") | ||
|
|
||
| var chainIDsLock sync.RWMutex |
There was a problem hiding this comment.
@olomix Do we really need sync.RWMutex here?
There was a problem hiding this comment.
What other options do we have to guard concurrent access to global dict?
We can use sync.Map. But typed map with lock I like more.
Kolezhniuk
approved these changes
Jan 30, 2024
vmidyllic
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.