IDEN-298 add subject position to claim #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olomix
requested changes
May 11, 2022
claim.go
Outdated
| @@ -324,6 +335,18 @@ func (c *Claim) GetSchemaHash() SchemaHash { | |||
| return schemaHash | |||
| } | |||
|
|
|||
| // GetSubjectPosition return a position where the subject is stored. | |||
| func (c *Claim) GetSubjectPosition() (SubjectPosition, error) { | |||
There was a problem hiding this comment.
Why do we need SubjectPosition type if we already have Subject?
I would propose just rename getSubject to GetSubject and that's it. Subject already a public type and all values of it are public too. I think we do not need another type. Return one of Subject constants would be fine.
claim.go
Outdated
| case SubjectOtherIdenValue: | ||
| return SubjectPositionValue, nil | ||
| default: | ||
| return "", errors.New("claim without ") |
There was a problem hiding this comment.
If you won't agree with my previous comment, then it looks like this error needs more text.
olomix
previously approved these changes
May 11, 2022
claim.go
Outdated
| subjectSelfFlag subjectFlag = iota // 000 | ||
| subjectInvalidFlag // 001 | ||
| subjectOtherIdenIndexFlag // 010 | ||
| subjectOtherIdenValueFlag // 011 |
There was a problem hiding this comment.
I would rename these constants like subjectFlagOtherIdenValue
olomix
approved these changes
May 11, 2022
demonsh
approved these changes
May 12, 2022
vmidyllic
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.