[GHA] Configured generic reactor workflow #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@ibexa-yuna I've tried to add generic reactor workflow to core. It works, but the linter itself generates warnings (see the job output and PR description). |
adamwojs
approved these changes
Jun 10, 2024
I think this is OKay and we just need to change the action in the reactee workflow |
|
Status: Before we merge this one, I was tasked to explore in more details what else we can add here (code style, tests). Almost all pieces are in place for that. |
konradoboza
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR configures generic reactor workflow. The aim here is to avoid repeating GHA configuration across dozens of maintained repositories. Instead we want to have one place to rule them all.
Known issues
Not related to the idea of this workflow, but just to the linter itself:
I already see that we're going to have an issue with Symfony flavor of Yaml:
!php/const,!tagged,!tagged_iterator, and more like that are valid expressions for Yaml interpreted by Symfony. I'm not sure if we can configure linter to take this into account.Documentation:
Internal tool already internally documentent.