+
Skip to content

IBX-10458: Implemented new Content Type search PHP API #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Oct 3, 2025
Merged

IBX-10458: Implemented new Content Type search PHP API #633

merged 27 commits into from
Oct 3, 2025

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Aug 12, 2025 •
edited
Loading

🎫 Issue IBX-10458

Caution

Table/column names/aliases mergup.

Description:

The ContentTypeService contract has been extended with a new method:

    public function findContentTypes(?ContentTypeQuery $query = null, array $prioritizedLanguages = []): SearchResult;

The ContentTypeQuery object receives the following arguments:

        ?CriterionInterface $criterion = null,
        array $sortClauses = [],
        int $offset = 0,
        int $limit = 25

And the available criterions are:

  • ContainsFieldDefinitionIds (joins field definitions and validates if a content type contains them)
  • ContentTypeGroupIds (joins content type group assignment table and searches for provided group ids)
  • Identifiers (content type identifiers)
  • Ids (content type ids)
  • IsSystem (joins content type group table via content type group assignment table and validates if group is system or not)
  • LogicalAnd
  • LogicalOr
  • LogicalNot

There are also available the following sort clauses:

  • Ibexa\Contracts\Core\Repository\Values\ContentType\Query\SortClause\Id
  • Ibexa\Contracts\Core\Repository\Values\ContentType\Query\SortClause\Identifiers
  • Ibexa\Contracts\Core\Repository\Values\ContentType\Query\SortClause\Name

Examplary query:

            new ContentTypeQuery(
                new LogicalOr([
                    new LogicalAnd([
                        new ContentTypeIdentifier(['folder', 'article']),
                        new ContentTypeGroupId([1]),
                    ]),
                    new ContentTypeIdentifier(['user']),
                ]),
            ),

For QA:

Documentation:

@barw4 barw4 self-assigned this Aug 12, 2025
@barw4 barw4 added the Feature New feature request label Aug 12, 2025
@barw4 barw4 force-pushed the ibx-10458-content-type-search-papi branch from 701a49c to 5c19221 Compare August 12, 2025 08:06
@barw4 barw4 marked this pull request as ready for review August 13, 2025 08:30
@barw4 barw4 requested a review from a team August 13, 2025 08:31
@ezrobot ezrobot requested review from Steveb-p, ViniTou, adamwojs, alongosz, ciastektk, konradoboza, mikadamczyk, tbialcz and wiewiurdp and removed request for a team August 13, 2025 08:31
adamwojs
adamwojs reviewed Aug 14, 2025
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's focus first on establishing final shape of the contracts.

@barw4 barw4 requested a review from adamwojs August 18, 2025 08:26
@barw4 barw4 mentioned this pull request Aug 20, 2025
Merged
@barw4 barw4 force-pushed the ibx-10458-content-type-search-papi branch from b3df6c4 to 0859ce5 Compare August 20, 2025 11:59
adamwojs
adamwojs reviewed Aug 20, 2025
View reviewed changes
@barw4 barw4 requested a review from adamwojs August 20, 2025 12:52
@barw4 barw4 mentioned this pull request Aug 22, 2025
Closed
@mnocon mnocon added the Doc needed The changes require some documentation label Sep 2, 2025
@barw4 barw4 force-pushed the ibx-10458-content-type-search-papi branch from 69eebef to 6d12b78 Compare September 23, 2025 10:31
@barw4 barw4 requested a review from ViniTou September 23, 2025 19:14
@barw4 barw4 mentioned this pull request Oct 1, 2025
Open
konradoboza
konradoboza approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a piece of solid work! 💪

Few nitpicks:

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 2, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@adamwojs adamwojs merged commit 6292902 into 4.6 Oct 3, 2025
24 checks passed
@adamwojs adamwojs deleted the ibx-10458-content-type-search-papi branch October 3, 2025 15:43
@adamwojs
Copy link
Member

adamwojs commented Oct 3, 2025 •
edited
Loading

You can merge up changes @barw4 (on Monday)

@barw4 barw4 mentioned this pull request Oct 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamwojs adamwojs adamwojs approved these changes

@konradoboza konradoboza konradoboza approved these changes

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@ciastektk ciastektk Awaiting requested review from ciastektk

@wiewiurdp wiewiurdp Awaiting requested review from wiewiurdp

@tbialcz tbialcz Awaiting requested review from tbialcz

@alongosz alongosz Awaiting requested review from alongosz

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

@barw4 barw4

Labels

Doc needed The changes require some documentation Feature New feature request Ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@barw4 @adamwojs @Steveb-p @alongosz @ViniTou @konradoboza @mikadamczyk @tischsoic @mnocon
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载