-
Notifications
You must be signed in to change notification settings - Fork 17
IBX-9060: Added bulk mark-as-read for user notifications #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bd92942
to
8414b4a
Compare
src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
217750d
to
1c05760
Compare
# Conflicts: # phpstan-baseline.neon
src/lib/Persistence/Legacy/Notification/Gateway/ExceptionConversion.php
Outdated
Show resolved
Hide resolved
…truct and simplify API
df5dcfa
to
11b8d00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a feeling that there's a code path here that should fail on PostgreSQL and is not covered by the integration test. Please double check following the diff remarks.
src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
652d838
to
b2e6533
Compare
…r improved safety
src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
tests/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabaseTest.php
Outdated
Show resolved
Hide resolved
src/lib/Persistence/Legacy/Notification/Gateway/DoctrineDatabase.php
Outdated
Show resolved
Hide resolved
ddfd835
to
f10727e
Compare
src/contracts/Repository/Decorator/NotificationServiceDecorator.php
Outdated
Show resolved
Hide resolved
…ty and removed redundant docblock
|
Description:
This pull request introduces a bulk mark-as-read functionality for user notifications. It allows users to efficiently mark multiple notifications as read in one action, streamlining notification management.