+
Skip to content

IBX-10263: Allowed hyphens in HostText and UriText siteaccess matchers #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

IBX-10263: Allowed hyphens in HostText and UriText siteaccess matchers #623

merged 1 commit into from
Jul 29, 2025

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Jul 22, 2025 •
edited
Loading

🎫 Issue IBX-10263

CI issues fixed in: #624

Description:

(Or we need documentation about possible characters in siteaccess name).

For QA:

Documentation:

@ViniTou ViniTou requested a review from a team July 22, 2025 13:48
@ezrobot ezrobot requested review from Steveb-p, adamwojs, alongosz, barw4, ciastektk, konradoboza, mikadamczyk, tbialcz and wiewiurdp and removed request for a team July 22, 2025 13:48
adamwojs
adamwojs approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@ViniTou ViniTou force-pushed the IBX-10263-fixed-host-text-regexp branch from df2733f to b57f9d4 Compare July 24, 2025 06:13
@micszo micszo self-assigned this Jul 28, 2025
@micszo micszo force-pushed the IBX-10263-fixed-host-text-regexp branch from b57f9d4 to 02cbf5c Compare July 28, 2025 13:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@micszo micszo mentioned this pull request Jul 28, 2025
Closed
micszo
micszo approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced and retested.

@micszo micszo removed their assignment Jul 28, 2025
@adamwojs adamwojs merged commit 0e3372e into 4.6 Jul 29, 2025
23 of 24 checks passed
@adamwojs adamwojs deleted the IBX-10263-fixed-host-text-regexp branch July 29, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamwojs adamwojs adamwojs approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@micszo micszo micszo approved these changes

@konradoboza konradoboza konradoboza approved these changes

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

@alongosz alongosz Awaiting requested review from alongosz

@ciastektk ciastektk Awaiting requested review from ciastektk

@barw4 barw4 Awaiting requested review from barw4

@wiewiurdp wiewiurdp Awaiting requested review from wiewiurdp

@tbialcz tbialcz Awaiting requested review from tbialcz

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

Labels

QA approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ViniTou @adamwojs @mikadamczyk @micszo @konradoboza @alongosz @tischsoic
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载