IBX-9727: Fixed strict types of IO layer #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5190307 to
2386c49
Compare
8bc7ef4 to
94ed9ac
Compare
adamwojs
reviewed
Jul 17, 2025
src/bundle/Core/Imagine/VariationPurger/LegacyStorageImageFileRowReader.php
Outdated
Show resolved
Hide resolved
203acad to
193bee5
Compare
adamwojs
approved these changes
Jul 30, 2025
src/bundle/IO/DependencyInjection/Compiler/IOConfigurationPass.php
Outdated
Show resolved
Hide resolved
193bee5 to
72a596b
Compare
konradoboza
approved these changes
Jul 30, 2025
tests/bundle/IO/DependencyInjection/ConfigurationFactory/MetadataHandler/FlysystemTest.php
Outdated
Show resolved
Hide resolved
* Added missing strict type hints and improved \Ibexa\Bundle\IO\EventListener\StreamFileListener
Co-Authored-By: Adam Wójs <adamwojs@users.noreply.github.com>
* Added missing type hints to: - \Ibexa\Tests\Bundle\IO\DependencyInjection\ConfigurationFactoryTestCase - \Ibexa\Tests\Bundle\IO\DependencyInjection\ConfigurationFactory\BinarydataHandler\FlysystemTest - \Ibexa\Tests\Bundle\IO\DependencyInjection\ConfigurationFactory\MetadataHandler\FlysystemTest - \Ibexa\Tests\Bundle\IO\DependencyInjection\ConfigurationFactory\BaseFlysystemTestCase * Fixed broken \Ibexa\Tests\Bundle\IO\DependencyInjection\ConfigurationFactory\MetadataHandler\FlysystemTest * Improved \Ibexa\Tests\Bundle\IO\DependencyInjection\ConfigurationFactory\BaseFlysystemTestCase
…tionFactory\BaseFlysystemTestCase
72a596b to
c824970
Compare
|
|
Update: rebased to align with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixed strict types of IO contracts and related implementations. Improved affected code.
The changes slightly overlap with
Ibexa\Bundle\Core\Imagine, however full refactoring of that namespace I'm gonna leave for later. The diff is already a bit too big.For QA:
ibexa:io:migrate-filesSymfony command probably requires manual testing.For Documentation:
Breaking v5.0.1 changes:
The contracts of the following interface received explicit strict types:
\Ibexa\Contracts\Core\IO\MimeTypeDetectorThe following contract classes' properties received explicit strict types:
\Ibexa\Contracts\Core\IO\BinaryFile\Ibexa\Contracts\Core\IO\BinaryFileCreateStructFull BC report using Roave/BackwardCompatibilityCheck:
https://gist.github.com/alongosz/11c82bcba6f3dc34574f00d32bf67c7d
(though we don't promise BC on non-contract namespaces, so that might not be very usable).