IBX-9980: Fixed displaying search engine in ibexa:reindex command
#607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steveb-p
approved these changes
Jul 1, 2025
alongosz
approved these changes
Jul 1, 2025
|
adamwojs
approved these changes
Jul 2, 2025
|
I will be your QA. Approved ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
It seems indexers can extend one of the following classes:
Ibexa\Core\Search\Common\IndexerIbexa\Core\Search\Common\IncrementalIndexerDespite all our indexers (Legacy/Solr/Elastic) extending the latter which already contains proper
getName()method, I foundSearchEngineIndexerFactorywhich looks like an EP accepting implementation of both mentioned services.I decided to handle those two cases within
getSearchEngineAliasmethod - custom indexers (implementingIbexa\Core\Search\Common\Indexer) should be handled the same way as in System infoServicestab.Additional change:
SymfonyStyle::confirmsecond parameter istrueby default, adjusted as such.For QA:
Documentation: