+
Skip to content

IBX-10167: Fixed translations export in abstract field type classes #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

IBX-10167: Fixed translations export in abstract field type classes #603

merged 1 commit into from
Jul 1, 2025

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Jun 25, 2025 •
edited
Loading

🎫 Issue IBX-10167

Description:

It seems like JMS\TranslationBundle\Translation\Extractor\File\TranslationContainerExtractor doesn't work well with abstract classes that are part of the TranslationContainerInterface interface:

In TranslationContainerExtractor.php line 112:
                                                                                                                                                      
  call_user_func(): Argument #1 ($callback) must be a valid callback, cannot call abstract method Ibexa\Core\FieldType\BaseNumericType::getTranslati  
  onMessages()

therefore I moved the interface into concrete classes.

For QA:

Documentation:

@barw4 barw4 self-assigned this Jun 25, 2025
@barw4 barw4 added Bug Something isn't working Ready for review labels Jun 25, 2025
@barw4 barw4 force-pushed the ibx-10167-fix-translation-export branch from c5d3bd7 to 64c2ed3 Compare June 25, 2025 07:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@barw4 barw4 requested a review from a team June 25, 2025 08:19
@ezrobot ezrobot requested review from Steveb-p, ViniTou, adamwojs, alongosz, ciastektk, mikadamczyk and wiewiurdp and removed request for a team June 25, 2025 08:19
@barbaragr barbaragr self-assigned this Jul 1, 2025
@alongosz alongosz merged commit 167d710 into main Jul 1, 2025
30 checks passed
@alongosz alongosz deleted the ibx-10167-fix-translation-export branch July 1, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barbaragr barbaragr barbaragr approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tbialcz tbialcz tbialcz approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

@alongosz alongosz Awaiting requested review from alongosz

@ciastektk ciastektk Awaiting requested review from ciastektk

@ViniTou ViniTou Awaiting requested review from ViniTou

@wiewiurdp wiewiurdp Awaiting requested review from wiewiurdp

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

@barw4 barw4

@barbaragr barbaragr

Labels

Bug Something isn't working QA approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@barw4 @adamwojs @mikadamczyk @alongosz @barbaragr @konradoboza @tbialcz @tischsoic
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载