IBX-9845: Added test skipping for Solr doesn't support shard URL #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9654798 to
0aac801
Compare
adamwojs
approved these changes
Jun 24, 2025
alongosz
reviewed
Jun 25, 2025
There was a problem hiding this comment.
What concerns me here is execution permissions (0755) added to this file for no reason
It doesn't look like any other test has that set:
There was a problem hiding this comment.
I don't think it's intentional change 😉
820c052 to
98e4f23
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This PR updates the SearchServiceTranslationLanguageFallbackTest integration test to address a breaking change introduced in Solr 9.3.0 (SOLR-9378), where the shard.url parameter is no longer sent in shard requests.
In Solr 9.3.0+, it is no longer possible to check the shard name via the response, as the shard.url is not available ("not a shard request" is returned). The assertIndexName() test assertion now only runs for Solr versions before 9.3.0. For Solr 9.3.0 and above, the assertion is skipped to avoid false negatives.
Impact of the new search_field sort clause:
Previously, test expectations around which search hit appeared at which index were based on results ordered solely by a single sort field. That ordering meant, for example, content A always showed at position 3 under a shared setup. Content should also be ordered by a secondary field, specifically "search_field". That's why searchHitIndex needs to be adjusted.
For QA:
Documentation: