IBX-10137: Moved slug transformation rules to production Resources #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
reviewed
Jun 10, 2025
src/lib/Resources/slug_converter/transformations/latin.tr.result.php
Outdated
Show resolved
Hide resolved
...lib/Persistence/TransformationProcessor/TransformationProcessorDefinitionBasedParserTest.php
Outdated
Show resolved
Hide resolved
…rserTest Co-Authored-By: Konrad Oboza <konradoboza@users.noreply.github.com>
Co-Authored-By: Konrad Oboza <konradoboza@users.noreply.github.com>
3585918 to
8d96454
Compare
|
konradoboza
approved these changes
Jun 10, 2025
adamwojs
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For quite some time we've had slug converter transformation rules used by production code residing in
tests/lib/Persistence/TransformationProcessor/_fixtures/transformations.I've moved these files to
src/lib/Resources/slug_converter/transformations/directory. For BC reasons pre-5.0.0 tagging is a good moment.Note that
trfile is a source for a corresponding compiledtr.resultfile. That's a custom format built by\Ibexa\Core\Persistence\TransformationProcessor\DefinitionBased\Parserand\Ibexa\Core\Persistence\TransformationProcessor\PcreCompilerSince
trgets compiled into a PHP array as the result, I've renamedtr.resulttotr.result.phpand applied standard CS.I've completely refactored SlugConverter test, but for now kept the other test changes to the bare minimum.
For QA:
No QA required. Regression run: ibexa/commerce#1339