+
Skip to content

IBX-10129: Replaced ValueObject with object for PermissionResolver #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 6, 2025
Merged

IBX-10129: Replaced ValueObject with object for PermissionResolver #580

merged 4 commits into from
Jun 6, 2025

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Jun 5, 2025 •
edited
Loading

🎫 Issue IBX-10129

Related PRs:

Description:

This will replace ValueObject with object, allowing more flexibility when using PermissionResolver.

For QA:

Documentation:

@Steveb-p Steveb-p mentioned this pull request Jun 5, 2025
Merged
@Steveb-p Steveb-p mentioned this pull request Jun 5, 2025
Merged
@Steveb-p Steveb-p force-pushed the permission-resolver-value-object branch from 990f648 to e624436 Compare June 5, 2025 20:45
@Steveb-p Steveb-p changed the title Replaced ValueObject with object for PermissionResolver IBX-10129: Replaced ValueObject with object for PermissionResolver Jun 6, 2025
@adamwojs adamwojs force-pushed the permission-resolver-value-object branch from e624436 to 3354fbd Compare June 6, 2025 12:32
@Steveb-p Steveb-p force-pushed the permission-resolver-value-object branch from 9f102f6 to bc639de Compare June 6, 2025 13:41
@Steveb-p Steveb-p force-pushed the permission-resolver-value-object branch from bc639de to 6c9ac17 Compare June 6, 2025 14:47
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@adamwojs adamwojs merged commit a2473ef into main Jun 6, 2025
8 of 10 checks passed
@adamwojs adamwojs deleted the permission-resolver-value-object branch June 6, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamwojs adamwojs adamwojs approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Steveb-p @adamwojs @ViniTou @konradoboza @mikadamczyk @alongosz @tischsoic
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载