IBX-9697: Added priority attribute to ibexa data collector #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
approved these changes
Mar 26, 2025
| } | ||
| } | ||
|
|
||
| usort($collectors, static fn ($a, $b) => $b['priority'] <=> $a['priority']); |
There was a problem hiding this comment.
Suggested change
| usort($collectors, static fn ($a, $b) => $b['priority'] <=> $a['priority']); | |
| usort($collectors, static fn (int $a, int $b): int => $b['priority'] <=> $a['priority']); |
ViniTou
approved these changes
Mar 26, 2025
konradoboza
approved these changes
Mar 26, 2025
Steveb-p
approved these changes
Mar 26, 2025
alongosz
reviewed
Mar 26, 2025
There was a problem hiding this comment.
@wiewiurdp please cover the use case in already existing DataCollectorPassTest.
added 3 commits
March 26, 2025 13:02
|
alongosz
approved these changes
Mar 26, 2025
mikadamczyk
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Added priority field to ibexa data collector