+
Skip to content

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Mar 3, 2025

Caution

Contains other PRs

Merge together with other IBX-8471 Pull Requests

🎫 Issue IBX-8471

Description:

Upgrading Symfony dependencies to version 7 along with necessary 3rd party packages and codebase changes.

Key changes:

  • [Composer] Dropped obsolete symfony/proxy-manager-bridge
  • [Composer] Bumped Symfony packages requirements to ^7.2
  • [Composer] Bumped 3rd party packages compatible with for Symfony 7

For QA:

Sanity tests and/or regression builds.

@alongosz alongosz force-pushed the ibx-8471-symfony-7 branch 5 times, most recently from b62a943 to cc1494b Compare April 7, 2025 13:59
@alongosz alongosz force-pushed the ibx-8471-symfony-7 branch 3 times, most recently from f4b1909 to 84347ec Compare April 16, 2025 15:44
Applied Rectors:
  * Rector\TypeDeclaration\Rector\ArrowFunction\AddArrowFunctionReturnTypeRector
  * Rector\TypeDeclaration\Rector\Class_\AddTestsVoidReturnTypeWhereNoReturnRector
  * Rector\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector
  * Rector\TypeDeclaration\Rector\ClassMethod\AddParamTypeBasedOnPHPUnitDataProviderRector
  * Rector\TypeDeclaration\Rector\ClassMethod\AddParamTypeFromPropertyTypeRector
  * Rector\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationBasedOnParentClassMethodRector
  * Rector\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector
  * Rector\TypeDeclaration\Rector\ClassMethod\BoolReturnTypeFromBooleanConstReturnsRector
  * Rector\TypeDeclaration\Rector\ClassMethod\BoolReturnTypeFromBooleanStrictReturnsRector
  * Rector\TypeDeclaration\Rector\ClassMethod\NumericReturnTypeFromStrictReturnsRector
  * Rector\TypeDeclaration\Rector\ClassMethod\NumericReturnTypeFromStrictScalarReturnsRector
  * Rector\TypeDeclaration\Rector\ClassMethod\ParamTypeByMethodCallTypeRector
  * Rector\TypeDeclaration\Rector\ClassMethod\ParamTypeByParentCallTypeRector
  * Rector\TypeDeclaration\Rector\ClassMethod\ReturnNeverTypeRector
  * Rector\TypeDeclaration\Rector\ClassMethod\ReturnNullableTypeRector
  * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromMockObjectRector
  * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromReturnDirectArrayRector
  * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromReturnNewRector
  * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictConstantReturnRector
  * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNativeCallRector
  * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictNewArrayRector
  * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictParamRector
  * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector
  * Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedPropertyRector
  * Rector\TypeDeclaration\Rector\ClassMethod\ReturnUnionTypeRector
  * Rector\TypeDeclaration\Rector\ClassMethod\StrictArrayParamDimFetchRector
  * Rector\TypeDeclaration\Rector\ClassMethod\StrictStringParamConcatRector
  * Rector\TypeDeclaration\Rector\ClassMethod\StringReturnTypeFromStrictScalarReturnsRector
  * Rector\TypeDeclaration\Rector\ClassMethod\StringReturnTypeFromStrictStringReturnsRector
  * Rector\TypeDeclaration\Rector\Class_\PropertyTypeFromStrictSetterGetterRector
  * Rector\TypeDeclaration\Rector\Class_\TypedPropertyFromCreateMockAssignRector
  * Rector\TypeDeclaration\Rector\Closure\AddClosureVoidReturnTypeWhereNoReturnRector
  * Rector\TypeDeclaration\Rector\Closure\ClosureReturnTypeRector
  * Rector\TypeDeclaration\Rector\Empty_\EmptyOnNullableObjectToInstanceOfRector
  * Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector
  * Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorRector
  * Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictSetUpRector
@alongosz alongosz force-pushed the ibx-8471-symfony-7 branch from 84347ec to cc1a15b Compare April 25, 2025 19:19
alongosz added 13 commits April 28, 2025 02:56
Doctrine DBAL upgrade was a combination of:
 * applying `DoctrineSetList` Rector sets,
 * manual code style fixes of Rector changes,
 * manual fixes of issues found by SonarQube PHPStorm plugin,
 * manual fixes of issues found by PHPStan.
Doctrine DBAL upgrade was a combination of:
 * applying `DoctrineSetList` Rector sets,
 * manual code style fixes of Rector changes,
 * manual fixes of issues found by SonarQube PHPStorm plugin,
 * manual fixes of issues found by PHPStan,
 * manual code quality improvements.
…od to remove PDO::FETCH_GROUP usage

Extracted getSubtreeContent `$onlyIds` behavior to a separate method as it applies to a different use case on a similar query.
adamwojs added 14 commits May 2, 2025 19:01
…:{testGetFieldDefinition,testHasFieldDefinition, testHasFieldDefinitionOfType} test
adamwojs added 6 commits May 4, 2025 08:05
…a\Core\FieldType\BinaryBase\BinaryBaseStorage\Gateway\DoctrineStorage
…Ibexa\Core\FieldType\BinaryFile\BinaryFileStorage\Gateway\DoctrineStorage
…e\Gateway\DoctrineStorage::removeMimeFromPath
…Ibexa\Core\Persistence\Legacy\Content\Gateway\DoctrineDatabase::deleteTranslatedFields
…xa\Core\Persistence\Legacy\Content\Gateway\DoctrineDatabase::deleteTranslationFromContentVersions
@adamwojs adamwojs force-pushed the ibx-8471-symfony-7 branch from d01f177 to 75fb207 Compare May 4, 2025 11:54
adamwojs added 3 commits May 4, 2025 13:57
…a\Core\Persistence\Legacy\Content\Gateway\DoctrineDatabase::deleteTranslationFromContentNames
…a\Core\Persistence\Legacy\Content\Gateway\DoctrineDatabase::deleteTranslationFromContentObject
…\Content\Common\Gateway\CriterionHandler\ContentName::toLowerCase
Copy link

sonarqubecloud bot commented May 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots
3.8% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载