IBX-8804: Moved PASSWORD_HASH_OAUTH2 from ibexa/oauth2-client
#419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a4f905d to
40fdf96
Compare
40fdf96 to
db88889
Compare
alongosz
approved these changes
Aug 22, 2024
ViniTou
approved these changes
Aug 23, 2024
glye
approved these changes
Aug 23, 2024
db88889 to
e91d560
Compare
|
katarzynazawada
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Mentioned password hash (renamed to
PASSWORD_HASH_INVALIDaccording to the specification) should be listed as one of the supported ones within Ibexa DXP since we offer OAuth2 integration out of the box. Besides moving it I did the following:src/contracts/Repository/Values/User/User.phpto increase quality,src/lib/Repository/User/PasswordHashServiceInterface.php,Error : Typed property Ibexa\Contracts\Core\Repository\Values\User\User::$login must not be accessed before initialization.The last code change however isn't a must, and we can introduce it later on on the occasion of deprecation removal. POV ping @alongosz.
For QA:
Documentation:
Mentioning new
PASSWORD_HASH_INVALIDmakes sense. We can also take a note it is utilized withinibexa/oauth2-client.