+
Skip to content

IBX-8469: Fixed image filtering by file size float value #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 21, 2024
Merged

IBX-8469: Fixed image filtering by file size float value #414

merged 5 commits into from
Aug 21, 2024

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Aug 8, 2024 •
edited
Loading

🎫 Issue IBX-8469

Description:

Float values in file size filter causes error when using solr search engine. This PR adds cast to int value converted to bytes and allows to use float values.

For QA:

Documentation:

@ciastektk ciastektk added the Bug Something isn't working label Aug 8, 2024
@ciastektk ciastektk requested a review from a team August 8, 2024 11:49
@ciastektk ciastektk changed the title IBX-8469: Fixed image filtering by image size float value IBX-8469: Fixed image filtering by file size float value Aug 8, 2024
Steveb-p
Steveb-p approved these changes Aug 8, 2024
View reviewed changes
@ciastektk ciastektk force-pushed the ibx-8469-fixed-image-file-size-filtering-by-float-values branch from 54bc30d to 3e7a7fa Compare August 9, 2024 10:07
@ciastektk ciastektk requested review from a team, Steveb-p, adamwojs and alongosz August 9, 2024 10:14
@ciastektk ciastektk force-pushed the ibx-8469-fixed-image-file-size-filtering-by-float-values branch from 3e7a7fa to 8f84db9 Compare August 9, 2024 13:11
Steveb-p
Steveb-p reviewed Aug 12, 2024
View reviewed changes
@bogusez bogusez self-assigned this Aug 20, 2024
@ciastektk ciastektk force-pushed the ibx-8469-fixed-image-file-size-filtering-by-float-values branch from 3edc25e to c3b9ef9 Compare August 20, 2024 11:47
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bogusez bogusez mentioned this pull request Aug 20, 2024
Closed
This was referenced Aug 20, 2024
Closed
Closed
@alongosz alongosz merged commit e8e81c8 into 4.6 Aug 21, 2024
@alongosz alongosz deleted the ibx-8469-fixed-image-file-size-filtering-by-float-values branch August 21, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@alongosz alongosz alongosz approved these changes

@konradoboza konradoboza konradoboza approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

+1 more reviewer

@bogusez bogusez bogusez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

@bogusez bogusez

Labels

Bug Something isn't working QA approved Ready for MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ciastektk @adamwojs @mikadamczyk @Steveb-p @alongosz @konradoboza @bogusez @tischsoic
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载