Add cache for WSI files #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestoarbitrio
approved these changes
Nov 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1408 1408
Branches 152 152
=========================================
Hits 1408 1408 Continue to review full report at Codecov.
|
alessiamarcolini
approved these changes
Nov 26, 2021
There was a problem hiding this comment.
Amazing 🙌🏼🥰
@patrick91 @ernestoarbitrio are we ready to merge?
|
We are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cache for WSI files in order to prevent downloading them all the time from the external servers.
An alternative could be to use Git LFS to store those files on the repo itself :)