Add method dispatcher compatible with older Python versions #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestoarbitrio
approved these changes
Aug 18, 2021
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1264 1272 +8
Branches 124 124
=========================================
+ Hits 1264 1272 +8
Continue to review full report at Codecov.
|
|
This pull request introduces 1 alert when merging e2e8824 into 79e9792 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an implementation of a type dispatcher for methods.
functools.singledispatcheris dispatching on the type of the first argument, which, for methods, is alwaysself.Therefore, in order to implement #311, I needed a method dispatcher compatible with all Python versions (
functools.singledispatchmethodis only available for Python 3.8+)Types of Changes
Issues Fixed or Closed by This PR
Checklist