+
Skip to content

Allow slide name to contain dot #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 13, 2021

Conversation

kheffah
Copy link
Collaborator

@kheffah kheffah commented Jul 12, 2021

If a slide name contains one or more dots in its middle, other than the extension, make sure to retain that in the self.name property of Slide.

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #281 (34260af) into master (f04b8a1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #281   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1236      1237    +1     
  Branches       117       117           
=========================================
+ Hits          1236      1237    +1     
Impacted Files Coverage Δ
src/histolab/slide.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f04b8a1...34260af. Read the comment docs.

@alessiamarcolini
Copy link
Collaborator

Hi @kheffah, thank you very much for your contribution!! 🙌
I'd have three requests for you:

  1. Could you please add one line of description for the PR?

  2. Could you use black on your code? If you install the pre-commit hooks it will check whether everything is fine for you.
    you only need to do pip install pre-commit and then pre-commit install (see https://pre-commit.com/ for reference)

  3. Could you please add one unit test that demonstrates the new behavior that is allowed now?
    The easiest option would be to add a new test case in the parametrization of https://github.com/histolab/histolab/blob/master/tests/unit/test_slide.py#L92

Please let me know if you have any questions or if you need support to fulfill these requests 💪

@kheffah
Copy link
Collaborator Author

kheffah commented Jul 13, 2021

@alessiamarcolini Thank you. All done.

@ernestoarbitrio ernestoarbitrio added this to the 0.2.6 milestone Jul 13, 2021
@ernestoarbitrio
Copy link
Member

@kheffah, this PR will be merged ASAP (after @alessiamarcolini review) and then it will be included in the 0.2.6 version that will be released today or tomorrow. Thanks for your contribution 😄 ❤️

@kheffah
Copy link
Collaborator Author

kheffah commented Jul 13, 2021

@kheffah, this PR will be merged ASAP (after @alessiamarcolini review) and then it will be included in the 0.2.6 version that will be released today or tomorrow. Thanks for your contribution

Sure thing :)

Copy link
Collaborator

@alessiamarcolini alessiamarcolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🙌

Thank you very much @kheffah for the contribution 🚀

@alessiamarcolini alessiamarcolini merged commit b96805a into histolab:master Jul 13, 2021
@kheffah kheffah deleted the allowdot branch August 7, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载