-
-
Notifications
You must be signed in to change notification settings - Fork 62
Allow slide name to contain dot #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow slide name to contain dot #281
Conversation
Codecov Report
@@ Coverage Diff @@
## master #281 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 1236 1237 +1
Branches 117 117
=========================================
+ Hits 1236 1237 +1
Continue to review full report at Codecov.
|
Hi @kheffah, thank you very much for your contribution!! 🙌
Please let me know if you have any questions or if you need support to fulfill these requests 💪 |
@alessiamarcolini Thank you. All done. |
@kheffah, this PR will be merged ASAP (after @alessiamarcolini review) and then it will be included in the |
Sure thing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a slide name contains one or more dots in its middle, other than the extension, make sure to retain that in the
self.name
property ofSlide
.