Instead of using the tissue box mask at level 0, keep it at thumbnail dimensions + drop sparse dependency #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The coverage report says:
How to test lines from 5 to 8? @ernestoarbitrio any advice? |
9778064 to
071a100
Compare
ernestoarbitrio
approved these changes
Aug 13, 2020
…imensions + drop sparse dependency
071a100 to
d1d89a8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix a critical memory issue, instead of calculating the tissue box mask at level 0 (and then scaling it to the extraction level), we can keep it at thumbnail dimensions and then scale accordingly all the subsequent operations.
We are dropping also the
sparsedependency (used to store the mask sparse array)