test: skip node-fetch and @whatwg-node/fetch tests on Node 21+ #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure appears to be unrelated to this PR |
|
I want to remove those entry points anyway. It shouldn't be Hattip's responsibility to polyfill fetch anymore (it made sense back in Node 14/16 days). |
|
Hmm, now I'm confused. My node v21.7.3. and v22.11.0 still accept |
|
Ah, looks like they removed it in v23 |
|
Well, otherwise CI would have started failing much earlier :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--no-experimental-fetchflag was removed in Node 21:nodejs/node#52611
When native fetch exists,
node-fetchand@whatwg-node/fetchpolyfills are not used. So in Node 21+, the integration tests for those polyfills are simply testing native fetch.Therefore, we can skip the integration tests for the
node-fetchand@whatwg-node/fetchpolyfills when the Node major version is 21 or higher.