Show exception context on assertion failure #11125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
Aug 4, 2025
ulysses4ever
reviewed
Aug 4, 2025
mpickering
commented
Aug 4, 2025
ulysses4ever
approved these changes
Aug 4, 2025
4be22c2 to
ebb6ae8
Compare
Since 9.12.2, it is not sufficient to call displayException, but you must also display the exception context as well. The `topHandler` now takes an argument which explains which exceptions are ones which are supposed to be displayed by the user (`VerboseException CabalException` or `VerboseException CabalInstallException`). Locations are not displayed for these exceptions. On the other hand, an assertion failure will always print a backtrace. Fixes #11090
ebb6ae8 to
d7dca69
Compare
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 9.12.2, it is not sufficient to call displayException, but you must also display the exception context as well.
The
topHandlernow takes an argument which explains which exceptions are ones which are supposed to be displayed by the user (VerboseException CabalExceptionorVerboseException CabalInstallException). Locations are not displayed for these exceptions.On the other hand, an assertion failure will always print a backtrace.
Fixes #11090
Please read Github PR Conventions and then fill in one of these two templates.
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: